feat(unstable): initial unstable nes implementation#754
Merged
Conversation
anna239
force-pushed
the
anna.zhdan/nes
branch
2 times, most recently
from
687715c to
6553230
Compare
benbrandt
force-pushed
the
anna.zhdan/nes
branch
from
6553230 to
1fb7a3b
Compare
benbrandt
reviewed
Mar 27, 2026
src/nes.rs
Outdated
| pub action_id: String, | ||
| /// Action parameters matching the schema from the client's capability. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub arguments: Option<serde_json::Value>, |
Member
There was a problem hiding this comment.
are the arguments really an arbitrary value? How does the caller know what to put in there?
Member
|
Do we want a "nes session close" method of some kind? |
benbrandt
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation for NES support